[V0 Deprecation] Remove placeholder attn #25510
Merged
+10
−354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
tdoublep
requested review from
NickLucche,
ApostaC and
LucasWilkinson
as code owners
tdoublep
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the placeholder attention backend and the associated is_attention_free flag, which is a good cleanup as it's no longer needed for Mamba models in V1. The changes are consistent across the modified files. However, I've found a broken test case that needs to be addressed to ensure the integrity of the test suite.
DarkLight1337
approved these changes
Sep 23, 2025
github-actions
bot
added
the
ready
tdoublep
requested review from
mgoin,
tlrmchlsmth,
WoosukKwon and
yewentao256
as code owners
WoosukKwon
approved these changes
Sep 23, 2025
yewentao256
approved these changes
Sep 23, 2025
xuechendi
added a commit
to vllm-project/vllm-gaudi
that referenced
this pull request
Sep 24, 2025
vllm-project/vllm#25510 Signed-off-by: Chendi Xue <Chendi.Xue@intel.com>
slokesha
pushed a commit
to slokesha/vllm-gaudi
that referenced
this pull request
Sep 24, 2025
vllm-project/vllm#25510 Signed-off-by: Chendi Xue <Chendi.Xue@intel.com> Signed-off-by: slokesha <slokeshappa@habana.ai>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
iboiko-habana
pushed a commit
to iboiko-habana/vllm-gaudi
that referenced
this pull request
Oct 2, 2025
vllm-project/vllm#25510 Signed-off-by: Chendi Xue <Chendi.Xue@intel.com> Signed-off-by: Iryna Boiko <iboiko@habana.ai>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove placeholder attention backend. It is no longer needed for Mamba models in V1, since each mamba/linear attention layer has its own "real" attention backend.
Test Plan
Let's see if CI passes
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.