Skip to content

Conversation

jmkuebler
Copy link
Contributor

@jmkuebler jmkuebler commented Sep 24, 2025

Purpose

#24845 introduced a wrong import which results in errors of pytest tests/v1/attention/test_attention_splitting.py.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
@mergify mergify bot added the v1 label Sep 24, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a broken import in tests/v1/attention/test_attention_splitting.py. The function create_ubatch_slices was being imported from vllm.v1.worker.ubatch_utils, but it is defined in vllm.v1.worker.ubatch_splitting. The change updates the import path to the correct location, which resolves the test failure mentioned in the description. The change is accurate and I have no further feedback.

@jmkuebler
Copy link
Contributor Author

@LucasWilkinson #24845 breaks the unit tests, because of a wrong import. This fixes it.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 24, 2025 08:48
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 24, 2025
@DarkLight1337 DarkLight1337 merged commit 58c360d into vllm-project:main Sep 24, 2025
25 of 27 checks passed
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants