[Bugfix][ROCm] Fixing trying to import non-existent symbols from libnccl.so #25605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix a crash on ROCm when certain NCCL symbols are not present by silently ignoring them during library initialization. However, the current implementation appears to be flawed. It checks if the function pointer is None, whereas ctypes is expected to raise an AttributeError for missing symbols. This suggests the fix may not work as intended. I have provided a suggestion to correctly handle missing symbols using a try...except block, which should make the fix more robust.
|
I'm not sure if it is better to exclude nccl specific functions like what you did here or include them like: #25608 |
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
That's also possible, only the condition should not be CUDA/ROCm, but ideally, NCCL version. |
SageMoore
reviewed
Sep 25, 2025
| "ncclCommWindowDeregister" | ||
| ]: | ||
| # These symbols require NCCL >= 2.27.03, and having | ||
| # an exception here on ROCm platform is not allowed |
There was a problem hiding this comment.
Can you add a logger.warn_once here that mentions that these symbols failed to import and that users should update their nccl/rccl libraries if they want to use them?
…nabled Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
SageMoore
approved these changes
Sep 25, 2025
5 tasks
|
I confirm that it is necessary to be able to run mGPU models in ROCM, it solves the following error: |
tlrmchlsmth
approved these changes
Sep 29, 2025
pdasigi
pushed a commit
to pdasigi/vllm
that referenced
this pull request
Oct 2, 2025
…ccl.so (vllm-project#25605) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
…ccl.so (#25605) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue from #24532
ncclCommWindowRegister and ncclCommWindowDeregister only exist on nccl >= 2.27.03
On ROCm having an unhandled exception (trying to import symbols in the above part of the code crashes graph capturing due to the
HIP error: operation not permitted when stream is capturingerror.I suppose the least invasive solution would be to swallow the import error on ROCm for these two symbols silently.
cc @Amir-19