Skip to content

[misc] warning by default for hanging / busy / idle #25627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2025
Merged

[misc] warning by default for hanging / busy / idle #25627

merged 3 commits into from
Sep 25, 2025

Conversation

youkaichao
Copy link
Member

@youkaichao youkaichao commented Sep 25, 2025 •
edited by github-actions bot
Loading

Purpose

Follow-up of #25566 and #9856 (comment)

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@youkaichao
warning by default
c605aee 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 25, 2025
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) September 25, 2025 11:50
tlrmchlsmth
tlrmchlsmth requested changes Sep 25, 2025
View reviewed changes
Copy link
Member

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change to info instead?

youkaichao
youkaichao commented Sep 25, 2025
View reviewed changes
youkaichao
youkaichao commented Sep 25, 2025
View reviewed changes
youkaichao
youkaichao commented Sep 25, 2025
View reviewed changes
Copy link
Member Author

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change

@youkaichao
Update vllm/distributed/device_communicators/shm_broadcast.py
0a1641f 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao
Update vllm/distributed/device_communicators/shm_broadcast.py
90f31d2 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) September 25, 2025 13:07
@youkaichao youkaichao disabled auto-merge September 25, 2025 13:14
@youkaichao youkaichao merged commit 6c340da into vllm-project:main Sep 25, 2025
9 of 14 checks passed
@youkaichao youkaichao deleted the warning_default branch September 25, 2025 13:15
Zhuul pushed a commit to Zhuul/vllm that referenced this pull request Sep 26, 2025
@youkaichao @Zhuul
[misc] log info messages by default for hanging / busy / idle (vllm-p…
d433abf 
…roject#25627)

Signed-off-by: youkaichao <youkaichao@gmail.com>
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
@youkaichao @yewentao256
[misc] log info messages by default for hanging / busy / idle (#25627)
a5fa821 
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youkaichao @tlrmchlsmth