[Model][Bugfix] Fix MiDashengLM audio encoder mask by removing incorrect logical_not
#25925
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In PR #25854, we addressed an issue in MiDashengLM’s audio encoder attention. The initial fix used a hand-written attention implementation, which, per review feedback, was then replaced with an SDPA-based implementation before merge.
SDPA interprets attention masks in the opposite way compared to our original hand-written code. To stay consistent, the previous logical inversion of the mask should have been removed. However, that adjustment was inadvertently omitted in the submitted changes, causing the audio encoder to produce incorrect embeddings.
This PR removes the leftover inversion and restores correct outputs from the MiDashengLM encoder.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.