Skip to content

Conversation

karan
Copy link
Contributor

@karan karan commented Oct 6, 2025

Purpose

The pkill is too broad and can kill other process with vllm in their path (for eg an unrelated script).

Test Plan

Tested locally.

Test Result

Works as expected.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Karan Goel <karangoel@google.com>
@mergify mergify bot added the performance Performance-related issues label Oct 6, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to make the pkill command more specific to avoid accidentally killing unrelated processes. The change from pkill -if vllm to pkill -if "vllm serve" is a good step in that direction. However, this approach is still brittle as it relies on matching the process command line string. I've suggested a more robust alternative that identifies and kills the server process by the port it's listening on (8004). This ensures that any server process using that port is terminated, regardless of how it was started, preventing potential script failures. Additionally, the warning in benchmarks/auto_tune/README.md about not having vllm in the script path is now outdated with your change and could be removed or updated.

@karan
Copy link
Contributor Author

karan commented Oct 6, 2025

@yaochengji Mind reviewing this? I messed up my git history in the previous branch.

Copy link
Collaborator

@yaochengji yaochengji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yaochengji yaochengji enabled auto-merge (squash) October 6, 2025 16:47
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 6, 2025
@yaochengji yaochengji merged commit 824a3f4 into vllm-project:main Oct 6, 2025
22 checks passed
southfreebird pushed a commit to southfreebird/vllm that referenced this pull request Oct 7, 2025
Signed-off-by: Karan Goel <karangoel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants