Fix: Output text is always truncated in some models #3016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use Yi-34B-Chat for inference based on vllm==0.3.2, the text in CompletionOutput is always truncated (see the example below). This PR ensures that when
stop_token_ids
is configured in thesampling_params
, it first checks for the existence of thestop_str
before truncating the sequence.Truncated CompletionOutput example: