[ROCm] Fix warp and lane calculation in blockReduceSum #3321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dllehr-amd
approved these changes
Mar 11, 2024
WoosukKwon
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
@kliuae Thanks for submitting the PR!
@dllehr-amd Thanks for the review!
starmpcc
pushed a commit
to starmpcc/vllm
that referenced
this pull request
Mar 14, 2024
dtransposed
pushed a commit
to afeldman-nm/vllm
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #3262 has addressed the issue of blockReduceSum using 32-thread warps in architecture supporting 64 as warp size. However, discrepancies were found in generation results before and after the fix, and the layernorm unit test unfortunately didn't pass on ROCm.
This PR adds fixes to these issues. It's been tested on MI210 and passes the layernorm unit test.