Skip to content

Conversation

cadedaniel
Copy link
Collaborator

@cadedaniel cadedaniel commented Apr 16, 2024

The AMD agent is recently hung by a contributor PR. We can bandaid-solve this by removing the constraint that all other tests wait for AMD/CPU tests before starting.

@cadedaniel cadedaniel changed the title [Draft] Move CPU/AMD tests to after wait [Draft] [CI] Move CPU/AMD tests to after wait Apr 16, 2024
@cadedaniel cadedaniel changed the title [Draft] [CI] Move CPU/AMD tests to after wait [CI] Move CPU/AMD tests to after wait Apr 16, 2024
@cadedaniel cadedaniel marked this pull request as ready for review April 16, 2024 22:57
@cadedaniel cadedaniel requested a review from simon-mo April 16, 2024 22:57
Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cadedaniel cadedaniel merged commit 11d652b into vllm-project:main Apr 17, 2024
@cadedaniel cadedaniel deleted the amd-test-after-wait branch April 17, 2024 05:53
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 21, 2024
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request Apr 22, 2024
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 26, 2024
alexeykondrat pushed a commit to alexeykondrat/ci-vllm that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants