Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fine-tune gptq_marlin configs to be more similar to marlin #4626

Merged

Conversation

alexm-neuralmagic
Copy link
Collaborator

test_gptq_marlin.py compares "gptq" outputs vs "gptq_marlin" outputs. However, sometimes, they can diverge a bit in their outputs. This PR ensures gptq_marlin uses more similar K/N breakdown configs to the original marlin to make the output more similar to gptq.

Copy link
Collaborator

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, LGTM!

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic enabled auto-merge (squash) May 9, 2024 00:12
@robertgshaw2-neuralmagic robertgshaw2-neuralmagic merged commit e288df0 into vllm-project:main May 9, 2024
59 checks passed
@robertgshaw2-neuralmagic robertgshaw2-neuralmagic deleted the marlin_8bit_fix branch May 9, 2024 00:14
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request May 9, 2024
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants