Skip to content

Conversation

wanmok
Copy link
Contributor

@wanmok wanmok commented Aug 9, 2023

According to the completion API doc, the API supports a string, array of strings, array of tokens, or array of token arrays. At the moment, the API only supports str | list[str].

In this PR, I made the following modifications:

  • extended the model protocol to support deserializing all these types in CompletionRequest
  • changed the completion API to detect the input type and respond accordingly

The PR has been rebased on the latest main, reformatted, and passed all tests.

@wanmok
Copy link
Contributor Author

wanmok commented Aug 11, 2023

I have reformatted the code to make it compatible with pylint. Please let me know if there is any concern to approve the PR.

Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution. Fixed some formatting errors and an accidentally deleted token_ids argument.

@zhuohan123 zhuohan123 merged commit e06f504 into vllm-project:main Aug 11, 2023
@wanmok
Copy link
Contributor Author

wanmok commented Aug 11, 2023

LGTM! Thank you for your contribution. Fixed some formatting errors and an accidentally deleted token_ids argument.

Thank you!

@wanmok wanmok deleted the rebase-on-vllm-main branch August 11, 2023 19:14
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
yma11 pushed a commit to yma11/vllm that referenced this pull request Jan 26, 2025
This PR enables multi step scheduling for encoder - decoder models
amy-why-3459 pushed a commit to amy-why-3459/vllm that referenced this pull request Sep 15, 2025
1. Upgrade vllm to 0.8.5
2. Drop 0.8.4 support
3. Keep doc to 0.8.4rc2 until we release 0.8.5

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants