Skip to content

Conversation

rafvasq
Copy link
Contributor

@rafvasq rafvasq commented Aug 7, 2024

Fixes #7274

  • Change function name from registrer_signal_handlers to register_signal_handlers

Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Copy link

github-actions bot commented Aug 7, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@simon-mo simon-mo merged commit ab0f5e2 into vllm-project:main Aug 7, 2024
@rafvasq rafvasq deleted the fix-registrer-handler branch August 7, 2024 16:35
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Alvant <alvasian@yandex.ru>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Misc]: Misspelled function register_signal_handlers
2 participants