explicitly del state #784
Merged
explicitly del state #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improvement to the memory management on machines with low CPU memory. Previously, the state variable was not explicitly deleted, leading to killed when your cpu mem is low
improvement to the memory management on machines with low CPU memory. Previously, the state variable was not explicitly deleted after its use, potentially leading to killed when you loading a big model in low cpu mem meachine.
explicitly del state
explicitly del state
randxie
pushed a commit
to randxie/vllm
that referenced
this pull request
Aug 29, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
yma11
pushed a commit
to yma11/vllm
that referenced
this pull request
Feb 25, 2025
When the input is 2D, we unsqueeze it to 3D to meet HPUFusedRMSNorm requirements
amy-why-3459
pushed a commit
to amy-why-3459/vllm
that referenced
this pull request
Sep 15, 2025
…llm-project#784) ### What this PR does / why we need it? In the w8a8 quantization code of `fused_experts`, the output of almost every operator is assigned a new variable name. If we want to save NPU memory, we manually `del` these variables to end their lifecycle, which fills the code with `del` statements and looks inelegant. Therefore, I plan to names the output of most operators as `hidden_states`, thereby ending the lifecycle of the previous `hidden_states`. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Signed-off-by: ApsarasX <apsarax@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improvement to the memory management on machines with low CPU memory. Previously, the state variable was not explicitly deleted after its use, potentially leading to killed when you loading a big model in low cpu mem meachine.