Fix mqa is false case in gpt_bigcode #806
Merged
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
requested changes
Aug 21, 2023
Comment on lines
55
to
56
| self.num_heads = \ | ||
| total_num_heads // self.tensor_model_parallel_world_size |
There was a problem hiding this comment.
Nit: Please use parenthesis for line continuation according to google python style guide.
Suggested change
| self.num_heads = \ | |
| total_num_heads // self.tensor_model_parallel_world_size | |
| self.num_heads = ( | |
| total_num_heads // self.tensor_model_parallel_world_size) |
Comment on lines
291
to
292
| num_heads = \ | ||
| total_num_heads // self.tensor_model_parallel_world_size |
Fixed. Please have a review again. @zhuohan123 |
zhuohan123
approved these changes
Aug 22, 2023
This was referenced Aug 22, 2023
randxie
pushed a commit
to randxie/vllm
that referenced
this pull request
Aug 29, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
amy-why-3459
pushed a commit
to amy-why-3459/vllm
that referenced
this pull request
Sep 15, 2025
vllm-project#806) ### What this PR does / why we need it? 1. Fix V1 error found by [nightly_ci](https://github.com/vllm-project/vllm-ascend/actions/runs/14950004754/job/41998136610), broken by [[v1] Pass BlockTable and KVCacheSpec to AttentionMetadataBuilders vllm-project#17483](vllm-project#17483), make `InputBatch` parameter consistent with vllm. 2. Disable benmark and fix it in upstream. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed --------- Signed-off-by: wangli <wangli858794774@gmail.com> Signed-off-by: Yikun Jiang <yikunkero@gmail.com> Co-authored-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @zhuohan123