graph: fix adding nameless specs #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
isaacs
reviewed
Nov 21, 2024
This changeset fixes adding nameless dependency specs to the cli e.g: `vlt install github:foo/bar` along with fixing inconsistencies when merging cli-defined dependencies with manifest-defined values. A few connected changes found when turning many stones related to this problem that are worthy of mention: - `Graph.removeNode` removes the edge from its `from` node instead of just unsetting the `to` value of that edge. - `append-nodes` will fix up and update entries in the user-provided `add` values, so that we can add a proper dependency name when writing to that importer `package.json` at the end of reify. - cleaned up the logic between `ideal.build` and its `get-importer-specs` module so values should be properly merged when adding / removing new dependencies. - updated a few tests and snapshots that had either wrong assumptions and / or bad fixture data
Make lockfile load a little more resilient by making sure it does not throw when trying to deconstruct values from a missing `options` property. Even though it should never be the case, we still had some internal tests that were confused by that, not to mention it might be a user surface that benefits from the extra resiliency despite not being a file that should be manually changed.
ruyadorno
force-pushed
the
ruyadorno/fix-adding-nameless-specs
branch
from
55110d2 to
663abf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes adding nameless dependency specs when using the cli
e.g:
vlt install github:foo/baralong with fixing inconsistencieswhen merging cli-defined dependencies with manifest-defined values.
A few connected changes found when turning many stones related to this
problem that are worthy of mention:
Graph.removeNoderemoves the edge from itsfromnode instead ofjust unsetting the
tovalue of that edge.append-nodeswill fix up and update entries in the user-providedaddvalues, so that we can add a proper dependency name when writingto that importer
package.jsonat the end of reify.ideal.buildand itsget-importer-specsmodule so values should be properly merged whenadding / removing new dependencies.
throw when trying to deconstruct values from a missing
optionsproperty.
and / or bad fixture data