Allow ENV variables to contain = symbols #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks for the addition. 👍 |
vlucas
added a commit
that referenced
this pull request
Oct 23, 2013
Allow ENV variables to contain = symbols
vlucas
pushed a commit
that referenced
this pull request
Dec 2, 2014
vlucas
pushed a commit
that referenced
this pull request
Jan 28, 2018
add tests and fix empty string evaluated as false
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into parsing errors when trying to save a database connection string as an ENV variable. It seemed to be truncating equal signs and everything after it. This pull request should take care of it.