Validations #118
Closed
Validations #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops - commented on the wrong PR - didn't notice you closed it and opened this one instead. Please check the comments on #117 - they all still apply to this one. |
|
Hey thanks for the tips. New to contributing so appreciate you helping me out. I did the changes and tested. It throws the error if its anything BUT solid numbers, so no periods, commas, percentage signs, and plus signs are able to pass by. |
| { | ||
| return $this->assertCallback( | ||
| function ($value) { | ||
| return (ctype_digit($value) == true); |
There was a problem hiding this comment.
The ctype_digit function already returns a boolean. Change this to return ctype_digit($value);.
|
What's wrong with |
|
We're missing tests. |
|
I've squashed and merged this. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added integer validations