Skip to content

[4.1] Refactor to use stores #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2019
Merged

[4.1] Refactor to use stores #395

merged 3 commits into from
Dec 12, 2019

Conversation

GrahamCampbell
Copy link
Collaborator

@GrahamCampbell GrahamCampbell commented Dec 12, 2019

I wasn't quite happy with the last PR. // cc @KarelWintersky, @sebastiansulinski.

Changes since the last PR:

  1. Dotenv\File namespace moved to Dotenv\Store\File.
  2. Dotenv\Dotenv constructor final param now expects an instance of Dotenv\Store\StoreInterface or an array of paths (string[]). There are no changes to the create... static methods of Dotenv\Dotenv`.
  3. Messy handling of possibly no files to read or no files could be read is now cleanly handled outside of the main dotenv class.

@GrahamCampbell GrahamCampbell merged commit 6a9494d into master Dec 12, 2019
@GrahamCampbell GrahamCampbell deleted the refactor branch December 12, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant