Skip to content
This repository was archived by the owner on Jul 19, 2022. It is now read-only.

Introduce parent artifact for the functions #11

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Conversation

sobychacko
Copy link
Contributor

In order to help with the release and maintenance of these function artifacts,
we need a new intermediate parent whose parent is spring-boot-starter-parent.

@sobychacko sobychacko requested a review from artembilan January 28, 2020 21:59
Copy link
Contributor

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On concern.

Plus the question about repackge goal.

Thanks

@@ -40,6 +41,7 @@
@SpringBootTest(properties = {
"spring.data.mongodb.port=0",
"mongodb.collection=testing"})
@Disabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this @Disabled?
What happened to tests?

@artembilan
Copy link
Contributor

@sobychacko ,

after merging David's PR for mongodb-consumer (#5), your one has to be rebased, please.

In order to help with the release and maintenance of these function artifacts,
we need a new intermediate parent whose parent is spring-boot-starter-parent.
@artembilan artembilan merged commit 11bd82f into master Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants