Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GKE #19

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Add support for GKE #19

merged 1 commit into from
Apr 14, 2020

Conversation

zubron
Copy link
Contributor

@zubron zubron commented Apr 13, 2020

GKE v1.15+ clusters use a version of the CIS benchmark that is tailored
to GKE clusters. To use this, the flag --benchmark needs to be passed
to kube-bench rather than --version. This updates the script that runs
kube-bench to check for the GKE distribution. If the Kubernetes version
is set and is less than 1.15, it defaults to the original --version
flag, otherwise it assumes --benchmark gke-1.0 should be used.

Signed-off-by: Bridget McErlean bmcerlean@vmware.com

@zubron zubron marked this pull request as draft April 13, 2020 22:50
@zubron
Copy link
Contributor Author

zubron commented Apr 13, 2020

The README needs to be updated with the GKE specific information.

@zubron zubron force-pushed the add-gke-support branch 5 times, most recently from f0c5a22 to 29ee947 Compare April 14, 2020 14:32
GKE v1.15+ clusters use a version of the CIS benchmark that is tailored
to GKE clusters. To use this, the flag `--benchmark` needs to be passed
to kube-bench rather than `--version`. This updates the script that runs
kube-bench to check for the GKE distribution. If the Kubernetes version
is set and is less than 1.15, it defaults to the original `--version`
flag, otherwise it assumes `--benchmark gke-1.0` should be used.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
@zubron zubron marked this pull request as ready for review April 14, 2020 14:35
@zubron zubron merged commit ecac4bc into vmware-tanzu:master Apr 14, 2020
@zubron zubron deleted the add-gke-support branch April 14, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant