Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
  • Loading branch information
Didainius committed Jun 28, 2023
1 parent 669835f commit 1cfad09
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .changes/v2.21.0/579-improvements.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
* External Network V2 now supports IP Spaces on VCD 10.4.1+ with new fields `UsingIpSpace` and
* `ExternalNetworkV2` now supports IP Spaces on VCD 10.4.1+ with new fields `UsingIpSpace` and
`DedicatedOrg` [GH-579]
2 changes: 1 addition & 1 deletion govcd/ip_space_org_assignment.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ func (ipSpace *IpSpace) GetOrgAssignmentByOrgId(orgId string) (*IpSpaceOrgAssign
return singleResult, nil
}

// Update updates Org Assignment
// Update Org Assignment
func (ipSpaceOrgAssignment *IpSpaceOrgAssignment) Update(ipSpaceOrgAssignmentConfig *types.IpSpaceOrgAssignment) (*IpSpaceOrgAssignment, error) {
client := ipSpaceOrgAssignment.vcdClient.Client
endpoint := types.OpenApiPathVersion1_0_0 + types.OpenApiEndpointIpSpaceOrgAssignments
Expand Down
4 changes: 2 additions & 2 deletions govcd/ip_space_uplink.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func (vcdClient *VCDClient) GetIpSpaceUplinkById(id string) (*IpSpaceUplink, err
return response, nil
}

// Update updates IP Space Uplink
// Update IP Space Uplink
func (ipSpaceUplink *IpSpaceUplink) Update(ipSpaceUplinkConfig *types.IpSpaceUplink) (*IpSpaceUplink, error) {
client := ipSpaceUplink.vcdClient.Client
endpoint := types.OpenApiPathVersion1_0_0 + types.OpenApiEndpointIpSpaceUplinks
Expand Down Expand Up @@ -155,7 +155,7 @@ func (ipSpaceUplink *IpSpaceUplink) Update(ipSpaceUplinkConfig *types.IpSpaceUpl
return result, nil
}

// Delete deletes IP Space Uplink
// Delete IP Space Uplink
func (ipSpaceUplink *IpSpaceUplink) Delete() error {
if ipSpaceUplink == nil || ipSpaceUplink.IpSpaceUplink == nil || ipSpaceUplink.IpSpaceUplink.ID == "" {
return fmt.Errorf("IP Space Uplink must have ID")
Expand Down

0 comments on commit 1cfad09

Please sign in to comment.