Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing multiple files related to documentation #1536

Merged
merged 9 commits into from
Jul 25, 2024

Conversation

naltanov
Copy link

Adding a topic about Kernel Live Patching.

Adding a topic about Kernel Live Patching.
@vmwclabot
Copy link
Member

@naltanov, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@naltanov, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@naltanov
Copy link
Author

naltanov commented Jan 22, 2024

This is a new topic that has passed technical review and received approval by Brennan Lamoreaux.

@vmwclabot
Copy link
Member

@naltanov, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

VMware employees do not need to sign a CLA to have changes merged to a repository owned by a VMware organization. If you are a member of a VMware GitHub organization, you will not be prompted to sign a CLA when opening a pull request. If you are a VMware employee and you are prompted to sign a CLA, close the pull request where you are prompted to sign the CLA and navigate to VMware's internal Upstream Contrib and join the desired VMware organization. Accept the invitation to join the org & open a new PR.

@naltanov
Copy link
Author

I have joined the vmware organization and should have the relevant permissions.

@dcasota
Copy link
Contributor

dcasota commented Mar 2, 2024

Hi @naltanov,

Can you have a look to content completeness?

  • content/en/docs-v4
  • content/en/docs-v3 -> accordingly to here, Photon OS 3.0 is eol, right?
  • spelling auto_livepauto_livepatch.sh and disenabled
  • As package builder, single system package consumer or cluster administrator, what has to be considered when using tdnf-automatic and auto_livepatch.sh? Are there known issues to avoid?

Better a fips chapter in installation guide?
See shim-15 readme. A comprehensive installation guide including step 5 would be helpful.

The open-source version of Photon OS has lost docs priority. Even as a Photon OS enthusiast it has become an odyssey to understand the guidelines. Good docs is gold.

@naltanov naltanov closed this Mar 7, 2024
@naltanov
Copy link
Author

naltanov commented Mar 7, 2024

Retrying to commit.

@naltanov naltanov reopened this Mar 7, 2024
@naltanov naltanov changed the title Create kernel-live-patching.md Changing multiple files related to documentation May 7, 2024
@naltanov naltanov closed this Jun 28, 2024
@naltanov
Copy link
Author

New changes

@naltanov naltanov reopened this Jun 28, 2024
@dcasota
Copy link
Contributor

dcasota commented Jun 28, 2024

@naltanov awesome++ pull content. Really a must with many new things.
I don't know why PhotonOS team seldom merges pull requests from the open source community and from internals. Curated docs are so important. Everybody remembers bad teachers and materials in school and after a few years the respect for good teachers remains permanently. This is not a regional phenomenon.
Could you have a look at #1478 ? It never got merged. From the content, it includes

  • fixes for orphan links, syntax
  • read-friendly indentation
  • New workstation 17.x pictures e.g. for uefi setups
  • gpu acceleration
  • wireless networking
  • build images
  • more information for Ph 3->4 and 4->5 upgrades

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants