Minor signature handling improvements #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works for both symlinks and reflinks. In no case does it do any true error handling for either one; it simply avoids creating symlinks if source doesn't exist in the pool, and reflinks if it can't open either end of the link. This is on the grounds that the detached signature files aren't strictly necessary for any purpose (as the database contains individual package signatures) and therefore there's no need to complain if they don't exist, and little need to complain if it can't create them.
| _cleanup_close_ int sigsrc = openat(repo->poolfd, signame, O_RDONLY); | ||
| _cleanup_close_ int sigdest = openat(repo->rootfd, signame, O_WRONLY | O_TRUNC, 0664); | ||
|
|
||
| if (sigdest < 0 && errno == ENOENT && sigsrc > -1) |
There was a problem hiding this comment.
Am I missing something or will this condition always be false? Since sigdest is opened last, if sigdest > 0, errno should be 0, right?
Never mind, I fail at reading comprehension.
|
Looks good, thank you very much! Appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got tired of waiting for #31 to be fixed, and also documented --sign. See commit messages for more detail.