Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(notebook): copy configs files from Google Drive #1064

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

Onako2
Copy link
Contributor

@Onako2 Onako2 commented Jan 21, 2024

Changes:

  • Added "import" for configs files
  • Added backing up of the config file if you accidentaly override it
  • Changed "clone" to export for configs files

Description of change

Made that you can also import the configs files from Google Drive because it takes long if you have to do it every time to copy paste the files.

The Pull Request Fixes #1063

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • This pull request follows Contributing.md
  • This pull request links relevant issues as Fixes #1063
  • pre-commit run -a passes with this change or ci passes
  • poetry run pytest passes with this change or ci passes
  • (There are new or updated unit tests validating the change)
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

Onako2 and others added 3 commits January 21, 2024 11:57
Changes:
- Added "import" for configs files
- Changed "clone" to export for configs files
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1c3614) 19.25% compared to head (10dc17b) 19.25%.
Report is 2 commits behind head on main.

❗ Current head 10dc17b differs from pull request most recent head f97fcc9. Consider uploading reports for the commit f97fcc9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   19.25%   19.25%           
=======================================
  Files          39       39           
  Lines        3496     3496           
  Branches      497      497           
=======================================
  Hits          673      673           
  Misses       2804     2804           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Onako2 Onako2 changed the title Added 'import' for configs files fix: Added 'import' for configs files Jan 21, 2024
@Onako2 Onako2 marked this pull request as draft January 21, 2024 11:16
@Onako2 Onako2 marked this pull request as ready for review January 21, 2024 11:17
@Onako2
Copy link
Contributor Author

Onako2 commented Jan 21, 2024

CI / Lint Commit Messages (pull_request)
Does somebody know how to fix that?

@34j 34j changed the title fix: Added 'import' for configs files chore(notebook): copy configs files from Google Drive Jan 22, 2024
@34j
Copy link
Collaborator

34j commented Jan 22, 2024

Thanks for your suggestion. It would be nice to have an error handling and an explanation that this operation is optional to avoid confusion.

@Onako2
Copy link
Contributor Author

Onako2 commented Jan 22, 2024

Thanks for your suggestion. It would be nice to have an error handling and an explanation that this operation is optional to avoid confusion.

Ok, I'll do it when I am home

@Onako2
Copy link
Contributor Author

Onako2 commented Jan 22, 2024

Thanks for your suggestion. It would be nice to have an error handling and an explanation that this operation is optional to avoid confusion.

How do you mean error handling?

Onako2 and others added 2 commits January 22, 2024 20:39
Added backing up when importing and exporting because maybe you accidentally override the config.json when importing/exporting. Just in case
@34j 34j merged commit adefc77 into voicepaw:main Jan 25, 2024
6 of 7 checks passed
@34j
Copy link
Collaborator

34j commented Jan 25, 2024

@allcontributors add Onako2 docs

Copy link
Contributor

@34j

I've put up a pull request to add @Onako2! 🎉

@34j 34j mentioned this pull request May 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for copying over Google Drive configs file to colab
2 participants