Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovim: update to 0.10.0 #50372

Merged
merged 3 commits into from
May 21, 2024
Merged

neovim: update to 0.10.0 #50372

merged 3 commits into from
May 21, 2024

Conversation

tranzystorekk
Copy link
Contributor

@tranzystorekk tranzystorekk commented May 16, 2024

Testing the changes

  • I tested the changes in this PR: YES

Neovim now depends on lua-lpeg as a library and dynamically links to it, but we don't serve it as a shlib.

@tranzystorekk tranzystorekk force-pushed the neovim branch 2 times, most recently from 8b0f3b4 to 10ce7ae Compare May 16, 2024 21:39
@classabbyamp
Copy link
Member

workaround:

- riscv64*) build_options_default="" ;;
+ armv7l|riscv64*) build_options_default="" ;;

@tranzystorekk tranzystorekk changed the title WIP neovim: update to 0.10.0 neovim: update to 0.10.0 May 16, 2024
@AnInternetTroll
Copy link
Contributor

Tested on x86_64-glibc with some LSPs. Works as expected, though I had
to :TSInstall some parsers again. Anyway, great work!

@classabbyamp
Copy link
Member

though I had to :TSInstall some parsers again

probably more related to the ABI break in treesitter

@ibhagwan
Copy link
Contributor

@tranzystorekk, ty for your work on this.

This build however is incomplete, it is missing lua the default treesitter parsers:

/lib/nvim/parser/bash.so
/lib/nvim/parser/c.so
/lib/nvim/parser/lua.so
/lib/nvim/parser/markdown.so
/lib/nvim/parser/markdown_inline.so
/lib/nvim/parser/python.so
/lib/nvim/parser/query.so
/lib/nvim/parser/vim.so
/lib/nvim/parser/vimdoc.so

This can result in neovim/neovim#27951, which you may not experience if you have nvim-treesitter plugin installed as it will compile the missing parsers.

@tranzystorekk
Copy link
Contributor Author

That would require packaging these parsers separately, and I don't have the bandwidth for that.

@ibhagwan
Copy link
Contributor

That would require packaging these parsers separately, and I don't have the bandwidth for that.

Why separately? When I build neovim locally and these are built inside the neovim build folder, isn’t this as simple as adding these files to the package?

Without these files the package is incomplete and will generate an error for example when opening lua files:
IMG_2104

@tranzystorekk
Copy link
Contributor Author

tranzystorekk commented May 19, 2024

Why separately? When I build neovim locally and these are built inside the neovim build folder, isn’t this as simple as adding these files to the package?

we explicitly don't invoke the cmake.deps step, and furthermore bundled deps need to be downloaded and our build_style cmake specifically disables network access so that doesn't happen.

@ibhagwan
Copy link
Contributor

Why separately? When I build neovim locally and these are built inside the neovim build folder, isn’t this as simple as adding these files to the package?

we explicitly don't invoke the cmake.deps step, and furthermore bundled deps need to be downloaded and our build_style cmake specifically disables network access so that doesn't happen.

So do you think this can be released as is without the libs or should we block merging of this package for a while?

Having an error and no highlights when opening a lua/markdown/etc file isn’t really acceptable IMHO.

@tranzystorekk
Copy link
Contributor Author

So do you think this can be released as is without the libs or should we block merging of this package for a while?

Now that I agree shouldn't happen.
I'll experiment with manually downloading the needed parser distfiles and invoking additional build steps to get them into neovim.

@ibhagwan
Copy link
Contributor

ibhagwan commented May 19, 2024

Ty @tranzystorekk for the latest pushes, works perfectly on glibc x86_64.

tranzystorekk and others added 3 commits May 20, 2024 00:06
neovim looks for a SONAME that is a whole path

find: warning: ‘-name’ matches against basenames only, but the given pattern
  contains a directory separator (‘/’), thus the expression will evaluate to
  false all the time.  Did you mean ‘-wholename’?
    SONAME: /usr/lib/lua/5.1/lpeg.so <-> lua51-lpeg>=1.1.0_2
@classabbyamp classabbyamp merged commit afea603 into void-linux:master May 21, 2024
8 checks passed
@tranzystorekk tranzystorekk deleted the neovim branch May 22, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants