Add ability to ignore everything listed in a specified file. #8
Conversation
|
@vokal/ios-developers Big ups to @vokal-isaac for his help - who wants to take a look at some delicious, delicious bash? |
There was a problem hiding this comment.
Do absolute paths work or do paths have to be relative to SRCROOT?
There was a problem hiding this comment.
They don't have to be - the actual .xcodecoverageignore file has to be relative to SRCROOT, but you can put whatever you damn well please in the file itself.
There was a problem hiding this comment.
You should also be able to use the * for file pattern matching, yes?
e.g. put _*.m to exclude mogenerator files
There was a problem hiding this comment.
That should definitely be doable, but I haven't tested it.
|
LGTM, but someone else should look at it, too. |
There was a problem hiding this comment.
Any interest in allowing for comments (lines starting with #?) in the ignore file?
There was a problem hiding this comment.
Yes, but for right now it just does nada if it can't find the given file, so #comments are effectively ignored.
Might be nice to add that in the future though.
|
👍 |
|
I haven't touched a bash script in ages, but it looks good to me |
|
Seems like we've got consensus on our end, I'll merge, open a PR back to the main fork, and let Jon Reid tell me what I'm doing wrong. 😄 |
Add ability to ignore everything listed in a specified file.
4 participants
No description provided.