Testing 1/3: Add a bunch of unit tests #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikrostew
force-pushed
the
unit-tests
branch
3 times, most recently
from
caa37f1
to
de81fda
Compare
dherman
requested changes
Aug 30, 2018
| @@ -24,6 +24,7 @@ pub struct NodeDistro { | |||
|
|
|||
| /// Check if the cached file is valid. It may have been corrupted or interrupted in the middle of | |||
| /// downloading. | |||
| // FIXME(#134) - verify checksum | |||
There was a problem hiding this comment.
Thanks for citing an issue! Let's use consistent formatting and write ISSUE(#134) instead of FIXME.
src/command/shim.rs
Outdated
| @@ -108,6 +108,7 @@ Options: | |||
| } | |||
| } | |||
|
|
|||
| // FIXME: all the logic here should be moved to notion-core | |||
| @@ -166,3 +181,173 @@ where | |||
| Ok(bin_map) | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
| pub mod tests { | |||
There was a problem hiding this comment.
I don't have a strong opinion either way, but you could consider splitting these out into a separate file. You'd create a manifest/ subdirectory, move manifest.rs into manifest/mod.rs, split out this module into manifest/test.rs, and then change this code to
#[cfg(test)]
pub mod tests;But I don't know if that's better or worse, just a thought.
There was a problem hiding this comment.
Good idea. And since you already refactored manifest.rs to manifest/mod.rs, this is an easy change
mikrostew
force-pushed
the
unit-tests
branch
from
de81fda
to
bc113ac
Compare
dherman
approved these changes
Sep 7, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the first part of improving the testing for Notion, I have added a bunch of unit tests.
Next up is creating an acceptance testing harness to tackle #7.