-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back to default Yarn if project Yarn is not set #470
Conversation
Is this ready to go? If so, I’ll review it and we can merge it! Sorry for the delay; I missed seeing it was open! |
Yeah, sorry I think I might have forgotten to mention it was out of draft state. Thanks! |
FWIW, I think GH needs to get better about notifications here. I don't think they send another notification when going from "Draft" to "Ready to review". |
CONFIRM, @rwjblue. I'm reviewing now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a solid fix and I think we should ship this so users stop hitting this issue… but I do have a question about whether this is exactly the right overall approach; it seems to me that between this and some of the stuff I've been doing in the volta list
implementation, we might have motivation to do some more substantial restructuring around this idea of the source and its relationship to the platform.
Created https://github.com/volta-cli/volta/projects/6#card-23308438 and https://github.com/volta-cli/volta/projects/6#card-23308348 to track possible future refactors brought up in PR Review. |
Closes #436
Info
yarn
within a project that doesn't have yarn specified, then we throw an error and require the user to runvolta pin yarn
to continue.volta install yarn
, so we do have a Yarn version available, we are just not using it.yarn
in your project, you should specify it there), but not require that they are done that way.yarn
specified.Changes
platform::Source
:ProjectNodeUserYarn
, that represents a merged platform.session::current_platform
, so that the fallback is available to any tool (as running other tools could result in runningyarn
, e.g.ember new --yarn
).Tested