Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move extras to this repo #101

Closed
vooon opened this issue Aug 11, 2014 · 11 comments
Closed

Move extras to this repo #101

vooon opened this issue Aug 11, 2014 · 11 comments
Milestone

Comments

@vooon
Copy link
Member

vooon commented Aug 11, 2014

On answers.ros.org i get recommendation to put all mavros packages in one repo.
With catkin it's easy: move mavros to subdirectory and copy mavros_extras.

Then i must examine how to change rosdistro info.

@vooon vooon added this to the Version 0.7.0 milestone Aug 11, 2014
@vooon vooon mentioned this issue Aug 11, 2014
5 tasks
@TSC21
Copy link
Member

TSC21 commented Aug 11, 2014

I can agree with that since when someone doesn't whant a certain plugin, just has to add it to the blacklist.

What's the status of the other issues right now?

@vooon
Copy link
Member Author

vooon commented Aug 11, 2014

All other issues related to 0.7 are closed (or moved to 0.8).
Seems that i can do release earlier, because now ros jenkins are broken by mavlink update:
mavros 0.6 don't build with new mavlink => mavlink repo package don't update => devel build broken because it want sub-rev4.

@TSC21
Copy link
Member

TSC21 commented Aug 11, 2014

So that means Mavlink has to be built from source right? Is the shadow repo with the sub-rev4 already so to download and install .dev?

@vooon
Copy link
Member Author

vooon commented Aug 11, 2014

Right, shadow must update after release.

@TSC21
Copy link
Member

TSC21 commented Aug 11, 2014

So can we move to 0.8 now? Or do we have to wait for the sub-rev4 repo release on ROS?

@vooon
Copy link
Member Author

vooon commented Aug 11, 2014

I think i'll move packages and then do release. Some things might be unstable, but it should fix ros buildfarm.

@TSC21
Copy link
Member

TSC21 commented Aug 11, 2014

Yeah probably! I see if I can get an hand on the mocap plugin so @tonybaltovski can test it. You have plans on what issue to face next on 0.8?

Note: @tonybaltovski so to test this on APM, you need to get a conversion done for the GPS coordinates. A parameter can be open so to choose to send GPS ou local position coordinates, but since mocap systems give local position, a conversion is needed to GPS, as you already know.

@vooon
Copy link
Member Author

vooon commented Aug 11, 2014

@TSC21
Copy link
Member

TSC21 commented Aug 11, 2014

So it's going to be from the bottom to the top, is that it?

@tonybaltovski
Copy link
Contributor

@vooon I don't believe they meant for you to move them to his repo but rather create a metapackage with many repos like:
mavros
--mavros_vision
--mavros_base
--etc

@vooon
Copy link
Member Author

vooon commented Aug 11, 2014

@tonybaltovski You understand correctly, but i don't create metapackage (special pkg with package.xml), but place all pkgs in subdirectories.

Almost done.

vooon added a commit that referenced this issue Aug 11, 2014
vooon added a commit that referenced this issue Aug 11, 2014
vooon added a commit that referenced this issue Aug 11, 2014
vooon added a commit that referenced this issue Aug 11, 2014
* mavros/master: (275 commits)
  move mavros to subdirectory, #101
  save changes before moving, #101
  plugins: setpoint: Update setpoint message name.
  plugin: setpoint_attitude: Update message name.
  Add link to ros-*-mavlink package wiki page.
  plugin: gps: Fix gcc 4.6 build (atomic).
  plugin: sys_status: Implement PX4 mode decoding.
  plugin: gps: Add EPH & EPV to diagnostic.
  plugin: gps: Move message processing to individual handlers.
  plugin: rc_io: Replace override service with topic. (ROS API change).
  Add dialect selection notes
  plugins: Change severity for param & wp done messages.
  plugins: Store raw autopilot & mav type values.
  plugins: init ctor (coverity)
  plugin: imu_pub: Add ATTITUDE_QUATERNION support.
  scriptis: mavcmd: Spelling
  scripits: Add mavcmd tool
  Add links to mavros_extras
  param: sys_status: Option to disable diagnostics (except heartbeat)
  plugin: command: Add takeoff and land aliases.
  ...
@vooon vooon closed this as completed in 2e1a8c8 Aug 11, 2014
vooon added a commit that referenced this issue Aug 11, 2014
vooon added a commit that referenced this issue Aug 11, 2014
* master: (56 commits)
  fix coverity, #101
  Add package index readme, Fix #101
  move exras to subdirectory, #101
  move mavros to subdirectory, #101
  save changes before moving, #101
  plugins: setpoint: Update setpoint message name.
  plugin: setpoint_attitude: Update message name.
  Add link to ros-*-mavlink package wiki page.
  plugin: gps: Fix gcc 4.6 build (atomic).
  plugin: sys_status: Implement PX4 mode decoding.
  plugin: gps: Add EPH & EPV to diagnostic.
  plugin: gps: Move message processing to individual handlers.
  plugin: rc_io: Replace override service with topic. (ROS API change).
  Add dialect selection notes
  plugins: Change severity for param & wp done messages.
  plugins: Store raw autopilot & mav type values.
  plugins: init ctor (coverity)
  plugin: imu_pub: Add ATTITUDE_QUATERNION support.
  scriptis: mavcmd: Spelling
  scripits: Add mavcmd tool
  ...

Conflicts:
	mavros/CHANGELOG.rst

Update coverity branch for #101.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants