Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTOPILOT_VERSION add to sys_status #96

Closed
2 tasks done
TSC21 opened this issue Aug 8, 2014 · 6 comments
Closed
2 tasks done

AUTOPILOT_VERSION add to sys_status #96

TSC21 opened this issue Aug 8, 2014 · 6 comments

Comments

@TSC21
Copy link
Member

TSC21 commented Aug 8, 2014

New message definitions has AUTOPILOT_VERSION, which can be useful to add to sys_status plugin.

Added by @vooon:

  • Wait while some one implement this message on FCU side
  • Extend UAS for store capabilities check
@vooon vooon added this to the Version 0.8.0 milestone Aug 11, 2014
@vooon vooon removed this from the Version 0.8.0 milestone Sep 11, 2014
@mhkabir
Copy link
Member

mhkabir commented Jan 29, 2015

@vooon APM has support for this now. I will add PX4 support if required.

@vooon
Copy link
Member

vooon commented Jan 29, 2015

Can't find how they do it in the code.
But seen PR for AUTOPILOT_VERSION_REQUEST, and as i remember @LorenzMeier wanted to send AUTOPILOT_VERSION periodically.

@vooon
Copy link
Member

vooon commented Mar 1, 2015

APM now sends AUTOPILOT_VERSION in response to command MAV_CMD_REQUEST_AUTOPILOT_CAPABILITIES.

@TSC21
Copy link
Member Author

TSC21 commented May 23, 2015

@vooon AUTOPILOT_CAPABILITIES is already supported on Firmware (PX4/PX4-Autopilot#2181). But testing it on mavros node start gave this result:

[ INFO] [1432376904.331698271]: VER: Capabilities 0x00000000000004eb
[ INFO] [1432376904.331779081]: VER: Flight software:     00000000 (j�?#Q6I`j�?#Q6I`)
[ INFO] [1432376904.331814379]: VER: Middleware software: 00000000 (j�?#Q6I`)
[ INFO] [1432376904.331850687]: VER: OS software:         00000000 (        )
[ INFO] [1432376904.331881663]: VER: Board hardware:      00000000
[ INFO] [1432376904.331912500]: VER: VID/PID: 26ac:0011
[ INFO] [1432376904.331939803]: VER: UID: 3432470a31323533

Something must not be right. Can't tell if this is on mavros side or firmware side.

@LorenzMeier
Copy link
Member

Its mavros. It should be printing the 8 bytes as hex, not as characters.

@TSC21
Copy link
Member Author

TSC21 commented May 23, 2015

Ok. I'll see what I can do then. Thanks!

Update: I think the reason is the APM sending the custom version array[8] as a string, as @vooon stated here: f07ca08#diff-e6ca3412eb7b4e4e7caab100190b2b9eR577 (can be seen here: https://github.com/diydrones/ardupilot/blob/78f02634d00a0962da4a3d15ed56e594cd40022d/libraries/GCS_MAVLink/GCS_Common.cpp#L1263). So code is adapted to APM. @LorenzMeier any reason custom version should be sent as strings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants