Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions Megahit after 1.1.4 do not contain megahit_toolkit? #226

Closed
dutchscientist opened this issue Jul 25, 2019 · 5 comments
Closed

Versions Megahit after 1.1.4 do not contain megahit_toolkit? #226

dutchscientist opened this issue Jul 25, 2019 · 5 comments

Comments

@dutchscientist
Copy link

Megahit is one of the dependencies for Shovill (Torsten Seemann, https://github.com/tseemann/shovill/), and with the new version of Megahit there is no "megahit_toolkit" anymore. This is a dependency that Shovill looks for when installed via Conda, and hence stops running.

I can find version 1.1.1 on Conda, but that only runs in Python 2.7 to 3.6, while Conda3 is now already at Python 3.7.

Is this by design? Issue at Shovill can be seen at:
tseemann/shovill#112

Would be great if this can be resolved, thanks :)

@voutcn
Copy link
Owner

voutcn commented Jul 26, 2019

It is removed after 1.1.4. Some useful sub-commands (including contig2fastg, the one used by Shovill) have been moved to megahit_core. To solve this, I will create an alias of megahit_core as megahit_toolkit in the next release (in one or two days).

@dutchscientist
Copy link
Author

Thank you, much appreciated! :)

@tseemann
Copy link

Thank you @voutcn and @dutchscientist for fixing this and maintaining backward compatibility!

@voutcn voutcn closed this as completed Jul 30, 2019
dpryan79 pushed a commit to bioconda/bioconda-recipes that referenced this issue Jul 31, 2019
- bwa
- flash
- libdeflate
- lighter
- perl-findbin
- pilon
- samtools
- seqtk
- skesa
- trimmomatic
- velvet
- shovill
- bwa/0.7.8

* Add license_file parameter

- bwa
- flash
- lighter
- seqtk
- velvet
- trimmomatic/0.32
- pilon

* Fix perl-findbin recipe

 - Made sure a test is present and that noarch: generic is specified

* Fix shovill megahit dependency issue

- Currently, shovill will only work with versions of megahit larger than
or equal to 1.2.7.

- This addresses issues tseemann/shovill#112 and voutcn/megahit#226 and #16545

- Added noarch: generic to build directive

* Fix velvet build recipe to use conda CC and CFLAGS env var

- Also changed the recipe to use Conda zlib

* Add patches to work with compiler envvars for seqtk, lighter, bwa/0.7.4 and bwa/0.7.8

- Patches the Makefile to make use of the LDFLAGS environmental variable
when it is available. This allows for the correct compilation under
Bioconda.

- seqtk patch has been submitted as a PR upstream: lh3/seqtk#142
- bwa patch has been submitted upstream: lh3/bwa#247
- lighter patch has been submitted upstream: mourisl/Lighter#22
kpalin pushed a commit to kpalin/bioconda-recipes that referenced this issue Aug 7, 2019
- bwa
- flash
- libdeflate
- lighter
- perl-findbin
- pilon
- samtools
- seqtk
- skesa
- trimmomatic
- velvet
- shovill
- bwa/0.7.8

* Add license_file parameter

- bwa
- flash
- lighter
- seqtk
- velvet
- trimmomatic/0.32
- pilon

* Fix perl-findbin recipe

 - Made sure a test is present and that noarch: generic is specified

* Fix shovill megahit dependency issue

- Currently, shovill will only work with versions of megahit larger than
or equal to 1.2.7.

- This addresses issues tseemann/shovill#112 and voutcn/megahit#226 and bioconda#16545

- Added noarch: generic to build directive

* Fix velvet build recipe to use conda CC and CFLAGS env var

- Also changed the recipe to use Conda zlib

* Add patches to work with compiler envvars for seqtk, lighter, bwa/0.7.4 and bwa/0.7.8

- Patches the Makefile to make use of the LDFLAGS environmental variable
when it is available. This allows for the correct compilation under
Bioconda.

- seqtk patch has been submitted as a PR upstream: lh3/seqtk#142
- bwa patch has been submitted upstream: lh3/bwa#247
- lighter patch has been submitted upstream: mourisl/Lighter#22
@JHarrisonEcoEvo
Copy link

It seems like there is still some problems with legacy megahit_toolkit commands not working.

I just tried the following command to convert contigs to fastg:

megahit_core contig2fastq 99 ../intermediate_contigs/k99.contigs.fa > k99.contigs.fastg

I also tried the previous accepted command of:

megahit_toolkit contig2fastq 99 ../intermediate_contigs/k99.contigs.fa > k99.contigs.fastg

Both provide the usage help to stdout but do not throw any errors or write anything to the output file. There is nothing germane in the usage prompt ( I copied it below for reference). My input contigs look like this (just first two contigs):

k99_0 flag=1 multi=3.0000 len=526
ACCCTGCTTTCCGAAGCGGGCGACACGGCCGCCGCGATCTCGGCCTTCTCGTCGATCGGCAAGGACCGCTCCGTTCCGGAAGCGATCCGCGATGCGGCCAAGCTGCGCGCCGGCTGGCTGCTGGTCGATACCGGCACCTATGAGCAGGTTTCCGCCGAGGTCGAGGAACTGTCGAATGACGGCAATCCGTTCCGCTTCTCCGCCCGCGAAATACTCGGACTGTCGGCCTATCGGCTGAAGGATTACACCCGCGCCCAGCAATGGTTCGAGGCGATTGCCAACGACCCGGAAGCCCCGCGCAACGTGCTCAACCGCGCCCAGATCATGCTCGAGGTGATGACCGCCGACGGCAATGTCGCCGAAAGCGCGGCCGGCCGATCAAGCTGTTCGACACCGCCGGCATGCGCCGCAAGGCGCGGGTGGTCGAAAAGCTGGAAAAGCTCTCGGTTTCCGACGCTCTGCGTGCGATCCGGTTTGCCGAATGCGTGGTGATCGTCTTCGATGCGACGATCCCGTTTGAAAAACA
k99_4539 flag=1 multi=3.0000 len=798
CAGCGCCTCGCCATTGTCTCCCACCAGGTCGGGGGCGAGCGCGCGAATGTCATAGGTCAGATCGACATCCTCGGAGAACCGCCGGATGACGCCATAGGCCTTCGACAGCGAAGTGCCGCCCTTGAATACCAGATGTTCGCCGAGCAGCGAGCCGTAGAGCGTGGCCAGCGCCCACACCACCCACGCATCCTTCTCCAGCAGGTGCGCGGGTCGGCCCGAGCGGTCGGCGGCAACGCTCAATGCTTCAAGGCGATCCTCGGCCGGAAGGAGGAGGAAGGGGTCAGCCATGCGCGACCTTACCCACGCTGCGCGCGAGCCAGGTCGGAAGCTGAGGCGCCGCCGCCACCAGCTCGCTGAAAGCGGCAGGCGGAAGCTTGCGCTTCAGGGTCTGGAGCGCCGACTCAGCCCTCTCCGGTCCGAGCCAAGCAAGCGCCCGCACCGCCTGTCCCGCCGGCCGATGCGCCATGGCAAGTTGCCAGCGCGGAGCGTGACGAAGCTCGACGGTCTGCTTGCCTAGGCTCATCTTCCGGGTGCGTCCCGAGGTCAGATAGACCGACCGGACCGGCACCTGCGTCGTAAGGCCGAGGCTGTTGGCGGCCGCCGCACCGCTTGAGACGATGACCTCGCCGCGCTGGGCTGCAAGCGCCTCAACCGCCTGCTCCACCGATGGCGCCCGGGTGCCGAACCGGCTCGTGACCGGCAGCAGATAAACACCTCGCCCGGCCCGAAGCAGTTGGCCCCGCTCGGCCAGACGCGACAAGGCCTGGTCCACCGCGGCGCGATTGCCAAGGTGGAGCA

What is printed when I run the above referenced calls to megahit_core or toolkit

Usage: megahit_core <sub_program> [sub options]
sub-programs:
assemble assemble from SdBG
local local asssembly
iterate extract iterative edges
buildlib build read library
count kmer counting
read2sdbg build sdbg from reads
seq2sdbg build sdbg from megahit contigs + edges
contig2fastg convert MEGAHIT's k*.contigs.fa to fastg format
readstat calculate read stats (# of reads, bases, longest, shortest, average)
filterbylen filter contigs by length
checkcpu check whether the run-time CPU supports POPCNT and BMI2
checkpopcnt check whether the run-time CPU supports POPCNT
checkbmi2 check whether the run-time CPU supports BMI2
dumpversion dump version
kmax the largest k value supported

@dutchscientist
Copy link
Author

I don't think this should be added here? Please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants