Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rubocop Naming/FileName #103

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Fix rubocop Naming/FileName #103

merged 1 commit into from
Mar 23, 2023

Conversation

jay7x
Copy link
Member

@jay7x jay7x commented Mar 23, 2023

No description provided.

bastelfreak
bastelfreak approved these changes Mar 23, 2023
View reviewed changes
.rubocop.yml
@@ -42,6 +38,7 @@ Naming/FileName:
Description: Some files violates the snake_case convention
Exclude:
- 'lib/beaker-docker.rb'
- Gemfile.local
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future we should really get rid of this file and just add beaker-rspec add development dependency in the gemspec

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we'll drop it after beaker release.. it's not really used anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or merge it into Gemfile: #104

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (aebfb28) 85.61% compared to head (d93e709) 85.61%.

❗ Current head d93e709 differs from pull request most recent head 221d5a8. Consider uploading reports for the commit 221d5a8 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files           1        1           
  Lines         292      292           
=======================================
  Hits          250      250           
  Misses         42       42

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bastelfreak bastelfreak merged commit c2885e4 into voxpupuli:master Mar 23, 2023
@jay7x jay7x deleted the fix_rubocop_yml branch March 23, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Implement Ruby 3.2 support
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jay7x @ekohl @bastelfreak