Cancel in-progress/pending workflows of the same branch #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
|
thanks for this, did you test the syntax on any module? |
Maybe I can test it here https://github.com/voxpupuli/puppet-example ? |
|
sure. you can add such a PR to all of our modules. |
ekohl
approved these changes
Aug 26, 2021
|
Tested in zabbix module. https://github.com/voxpupuli/puppet-zabbix/actions/runs/1169817369 was cancelled automatically |
|
Also re-triggered this job just to be sure it doesn't interfere with other PRs |
root-expert
changed the title
smortex
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrency setting documentation.
This PR introduces a Travis-like behavior which was cancelling any previous jobs when new changes were pushed.
This can help with modules whose acceptance tests are time consuming and stacking up workflows can lead to hit the concurrency limit pretty quickly.
A example could be the voxpupuli/puppet-zabbix module whose acceptance tests are lasting up to an hour, if a contributor pushes 5 changes we end up with ~60 jobs in the queue.
Caveats:
I haven't thought of all the cons of this change, so I'm open to discussion 😄