Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow concat module version up to 4.1.1 #61

Merged
merged 2 commits into from
Dec 19, 2017
Merged

Conversation

Yyuzu
Copy link
Contributor

@Yyuzu Yyuzu commented Dec 17, 2017

PR following #60

metadata.json Outdated
@@ -38,7 +38,7 @@
},
{
"name": "puppetlabs/concat",
"version_requirement": ">= 1.2.5 < 3.0.0"
"version_requirement": ">= 1.2.5 <= 4.1.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we only limit on majors. All other modules are also < 5.0.0 since we trust them to use semver.

@Yyuzu
Copy link
Contributor Author

Yyuzu commented Dec 17, 2017

I see :-)
I hope I did it right, tell me if it failed !

@ekohl ekohl merged commit 34a9fdf into voxpupuli:master Dec 19, 2017
@Yyuzu Yyuzu deleted the patch-1 branch December 19, 2017 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants