Test with future parser #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only Puppet 3.5 for now; rspec-puppet doesn't work with anything higher. Allow failures since future parser is still pre-release.
* concat::fragment requires 'order' to be a string * init parameters added in #373 referred to wrong variable name in params.pp * cannot perform regex match on a number, so make {fastcgi,proxy}_cache_levels a string by default * bug fixed in test suite
|
Nice idea. 🤘 |
|
Interesting that the issue raised in #322 didn't trigger any error with future parser... I'm not sure if that code just wasn't touched by the spec tests but I wouldn't think so. Anyway please merge if you're happy with this. It's definitely worth having in the test matrix as it did uncover a few bugs already. |
|
Be aware that the bug where order didn't allow for integer has been fixed in puppetlabs/puppetlabs-concat#185 |
|
So if we use concat module 1.1.0 we have the issue with strings but if we use the 1.0.4 there is no issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a string by default