Add pg_hba rule to allow zabbix server #411 #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a pg_hba rule to aways add this rule for allow zabbix server connect to database. voxpupuli#411
|
Hi @RaphaelNeumann, thanks for the patch. Can you take a look at the failing spec tests? |
|
@bastelfreak of course... I will send fix soon |
|
@bastelfreak It's there :D |
bastelfreak
reviewed
Jun 23, 2017
manifests/database.pp
Outdated
|
|
||
| # When every component has its own server, we have to allow those servers to | ||
| # access the database from the network. Postgresl allows this via the |
There was a problem hiding this comment.
typo: Postgresl -> Postgresql
bastelfreak
reviewed
Jun 24, 2017
spec/classes/database_spec.rb
Outdated
| @@ -65,6 +66,32 @@ | |||
| it { is_expected.to contain_class('zabbix::params') } | |||
| end | |||
|
|
|||
| describe 'database_type is postgresql, zabbix_type is server and zabbbix_server anda zabbix_web in the some server but zabbix_database is on other server' do | |||
bastelfreak
reviewed
Jun 24, 2017
| # of server and web has to be supplied as an parameter. | ||
| if $zabbix_web_ip != $zabbix_server_ip { | ||
| # When database not in some server with zabbix server include pg_hba_rule to server | ||
| if ($database_host_ip != $zabbix_server_ip) or ($zabbix_web_ip != $zabbix_server_ip){ |
There was a problem hiding this comment.
is this logic correct? Shouldn't it be: if ($database_host_ip != $zabbix_server_ip){} ?
There was a problem hiding this comment.
Yes, I agree with this logic, but on current and old versions of this module has this rule, if I change this logic, current implements will stop working.
For warrant the retro-compatibility I just added an "or" condition for this existent rule.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pg_hba rule to aways add this rule for allow zabbix server connect to database. #411