Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View of structured facts #452

Merged
merged 1 commit into from
Apr 15, 2019
Merged

View of structured facts #452

merged 1 commit into from
Apr 15, 2019

Conversation

emlun007
Copy link
Contributor

@emlun007 emlun007 commented Feb 14, 2018 •
edited
Loading

Line breaks were added allowing see the facts in a structured way, e.g. for disks:

view_of_facts

@coveralls
Copy link

coveralls commented Feb 14, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 81.76% when pulling ad10336 on emlun007:master into b993991 on voxpupuli:master.

@emlun007 emlun007 mentioned this pull request Feb 14, 2018
Closed
othalla
othalla approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@othalla othalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@alexjfisher
Copy link
Member

Looks ok, and is an improvement. networking fact looks a bit funky (repeated new lines etc).

@othalla
Copy link
Contributor

othalla commented Apr 13, 2019

Anything blocking the merge?

@alexjfisher alexjfisher merged commit dc5ff9c into voxpupuli:master Apr 15, 2019
@alexjfisher
Copy link
Member

@emlun007 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@othalla othalla othalla approved these changes

@alexjfisher alexjfisher alexjfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emlun007 @coveralls @alexjfisher @othalla @yakatz