-
Notifications
You must be signed in to change notification settings - Fork 23
Closed
Description
glowscript/lib/opentype/poly2tri.js
Lines 43 to 68 in c65dabf
// -------------------------------------------------------------------------Node | |
/** | |
* Advancing front node | |
* @constructor | |
* @private | |
* @struct | |
* @param {!XY} p - Point | |
* @param {Triangle=} t triangle (optional) | |
*/ | |
var Node = function(p, t) { | |
/** @type {XY} */ | |
this.point = p; | |
/** @type {Triangle|null} */ | |
this.triangle = t || null; | |
/** @type {Node|null} */ | |
this.next = null; | |
/** @type {Node|null} */ | |
this.prev = null; | |
/** @type {number} */ | |
this.value = p.x; | |
}; | |
Above Node
definition overwrites DOM Node Interface, and breaks several basic DOM functionalities. (Check this issue)
I found that simpe renaming strategy works, but I cannot recommend this for the solution. Because poly2tri
has original implementation, and it is better to keep them in sync.
I think using original poly2tri implementation could be possible. Because jupyter extension environment has been changed a lot for 5 years. I have not tested this.
Metadata
Metadata
Assignees
Labels
No labels