Skip to content

poly2tri.js overwrites DOM Node Interface #160

@a3626a

Description

@a3626a

// -------------------------------------------------------------------------Node
/**
* Advancing front node
* @constructor
* @private
* @struct
* @param {!XY} p - Point
* @param {Triangle=} t triangle (optional)
*/
var Node = function(p, t) {
/** @type {XY} */
this.point = p;
/** @type {Triangle|null} */
this.triangle = t || null;
/** @type {Node|null} */
this.next = null;
/** @type {Node|null} */
this.prev = null;
/** @type {number} */
this.value = p.x;
};

Above Node definition overwrites DOM Node Interface, and breaks several basic DOM functionalities. (Check this issue)

I found that simpe renaming strategy works, but I cannot recommend this for the solution. Because poly2tri has original implementation, and it is better to keep them in sync.

I think using original poly2tri implementation could be possible. Because jupyter extension environment has been changed a lot for 5 years. I have not tested this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions