Incompatibility with Python 3.3 #6

Open
Arfrever opened this Issue Sep 27, 2012 · 0 comments

1 participant

@Arfrever

Build system builds cvisualmodule.so, but such names are no longer supported in Python 3.3:
http://bugs.python.org/issue14040
http://hg.python.org/cpython/rev/42f61304f77d

cvisualmodule.so should be renamed to cvisual.so.

--- acinclude.m4
+++ acinclude.m4
@@ -148,7 +148,7 @@
   dnl Query distutils for this directory.  distutils does not exist in
   dnl Python 1.5, so we fall back to the hardcoded directory if it
   dnl doesn't work.
-  dnl Change to put cvisualmodule in vis folder
+  dnl Change to put cvisual in vis folder
   dnl AC_CACHE_CHECK([for $am_display_PYTHON extension module directory],
   dnl   [am_cv_python_pyexecdir],
   dnl   [am_cv_python_pyexecdir=`$PYTHON -c "from distutils import sysconfig; print(sysconfig.get_python_lib(1,0,prefix='$PYTHON_EXEC_PREFIX').replace('\\\\\','/'))" 2>/dev/null ||
--- src/gtk2/makefile
+++ src/gtk2/makefile
@@ -2,12 +2,12 @@
 # to the autoconf build machinery. This file is unlikely to be kept up to date.
 # Its purpose is just to show the main features of a Visual build, without the
 # complexity of the autoconf mechanisms. It deals only with the building and
-# installing of cvisualmodule.so, not with installing the other components (help etc.)
+# installing of cvisual.so, not with installing the other components (help etc.)

 # Place a copy of this make file in a directory parallel to vpython-core2.
 # Be sure to specify what version of Python.
 # In vpython-core2/gtk2, run "sudo make setup" to establish links that make
-# it unnecessary to move cvisualmodule.so into the actual site-packages directory.
+# it unnecessary to move cvisual.so into the actual site-packages directory.

 prefix = /usr
 PYTHON_VERSION = 2.6
@@ -76,13 +76,13 @@
 %.o: %.cpp
    $(CXX) $(CVISUAL_CPPFLAGS) $(CVISUAL_CXXFLAGS) -MMD -MF $*.d -MT "$*.d $*.lo" -c -o $@ $<

-cvisualmodule.so : $(CVISUAL_OBJS)
-   $(CXX) -shared $(CVISUAL_OBJS) $(CVISUAL_LIBS) -o cvisualmodule.so
+cvisual.so : $(CVISUAL_OBJS)
+   $(CXX) -shared $(CVISUAL_OBJS) $(CVISUAL_LIBS) -o cvisual.so

-# -rpath /usr/lib/python$(PYTHON_VERSION)/site-packages/cvisualmodule.la
+# -rpath /usr/lib/python$(PYTHON_VERSION)/site-packages/cvisual.la

-install : cvisualmodule.so
-   cp cvisualmodule.so ../vpython-core2/site-packages/visual
+install : cvisual.so
+   cp cvisual.so ../vpython-core2/site-packages/visual
 #  sudo cp cvisual.so /Library/Frameworks/Python.framework/Versions/$(PYTHON_VERSION)/lib/python$(PYTHON_VERSION)/site-packages/
 #  sudo cp cvisual.so /Library/Python/$(PYTHON_VERSION)/site-packages

--- src/Makefile.in
+++ src/Makefile.in
@@ -203,7 +203,7 @@
        $(GTHREAD_LIBS) /sw/lib/libboost_python-mt.a -lboost_thread-mt -lboost_signals)
     CXX_RULE = $(DEFAULT_CXX_RULE)
     LINK_RULE = $(OSX_SORULE)
-    PLATFORM_TARGET = cvisualmodule.so
+    PLATFORM_TARGET = cvisual.so
     CVISUAL_CPPFLAGS += $(OSX_CPPFLAGS)
     INSTALL_RULE = $(GENERIC_INSTALLRULE)
  else
@@ -217,7 +217,7 @@
 #    -l$(top_srcdir)/dependencies/boost_files/linux_libs/boost_thread)
     CXX_RULE = $(LT_CXX_RULE)
     LINK_RULE = $(LT_LINKRULE)
-    PLATFORM_TARGET = cvisualmodule.la
+    PLATFORM_TARGET = cvisual.la
     CVISUAL_LIBS += -lstdc++
     INSTALL_RULE = $(LT_INSTALLRULE)
   endif
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment