VPython labextension support on remote host. #36
Conversation
|
Hi Matt This failed on the Mac build but I only changed 1 line of code in the vpython file with_notebook.py . The other file changes had to do with the vpython labextension which I don't think are part of your build. I think you were working on fixing a Mac build issue with a different pull request and that problem is why this build failed. John |
|
I'm going to see if I can reproduce the mac problem tonight. |
|
Well, I can make the problem happen on my local mac. No idea why it happens yet. What was odd about this is that there wasn't any change in our code that brought this on, so I'm going to check to see if there were some recent conda releases that broke something. |
|
@jcoady -- I just merged a fix for the test failure (there is something wrong with python 3.7.4 from conda and with conda build 3.8.10 so I'm using earlier versions of each). Can you rebase this to pull in the latest changes? If you haven't rebased before or want me to do the rebase and push it to your branch please let me know. |
|
Hi Matt, Can you perform the rebase for me and push it to my branch. Thanks |
For JupyterLab version 1.0.0 and higher we no longer need to copy vpython_data files to appropriate directory. It is now handled in the Jupyter labextension for vpython.
Updated for WebSocket support for vpython running on a remote proxy server.
Updated to support vpython labextension on Jupyterlab version > 1.0.0 .
Updated to support websockets on remote host.
|
Hi John,
I just did the rebase and pushed it.
Matt
…On Oct 24, 2019, 5:53 PM -0500, john ***@***.***>, wrote:
Hi Matt,
Can you perform the rebase for me and push it to my branch.
Thanks
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Thanks Matt |
Made changes to enable the vpython labextension to work with JupyterLab running on a remote host such as binder or JupyterHub.