PR: Don't call os.kill on Windows if running inside Spyder #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @dalthviz for finding the cause for this! @BruceSherwood, @mwcraig, before this Spyder crashed with a segfault on Windows after closing the browser tab where VPython is displayed. |
dalthviz
changed the title
dalthviz
changed the title
…erver (Spyder case)
dalthviz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the change basically prevents calling
os.killon Windows while running inside Spyder and instead just raise aKeyboardInterruptFixes spyder-ide/spyder#12300
The missing thing here is add a way to prevent showing the traceback generated by raising the exception inside Spyder.Pinging @ccordoba12 just in case