Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear what version of geth or openethereum ethnode is running at the moment #19

Closed
TimDaub opened this issue May 16, 2021 · 1 comment · Fixed by #21
Closed

Unclear what version of geth or openethereum ethnode is running at the moment #19

TimDaub opened this issue May 16, 2021 · 1 comment · Fixed by #21

Comments

@TimDaub
Copy link
Contributor

TimDaub commented May 16, 2021

Problem:

I want to file a bug over at openethereum/openethereum, but for that I need to know which version of e.g. openethereum ethnode is currently running.

Ideas:

  1. When running --version, ethnode could also show the version of the underlying Ethereum node
  2. We could allow passing arguments through ethnode to the Ethereum node
  3. We could introduce a new option to retrieve the Ethereum node version
TimDaub added a commit to TimDaub/ethnode that referenced this issue May 16, 2021
@TimDaub
Allow passing arguments directly to Ethereum node
5fe689c 
- Fixes vrde#19
TimDaub added a commit to TimDaub/ethnode that referenced this issue May 16, 2021
@TimDaub
Allow passing arguments directly to Ethereum node
79a2168 
- Fixes vrde#19
@TimDaub TimDaub mentioned this issue May 16, 2021
Merged
@TimDaub
Copy link
Contributor Author

TimDaub commented May 16, 2021 •
edited
Loading 

1. When running `--version`, ethnode could also show the version of the underlying Ethereum node

I looked at the feasibility of implementing this, but to me it seemed unnecessarily complicated for such a simple thing. I ended up allowing the direct passing of arguments to the nodes (2) which fixed the problem with a minimal set of changes to the code.

@vrde vrde closed this as completed in #21 May 16, 2021
vrde pushed a commit that referenced this issue May 16, 2021
@TimDaub
Allow passing arguments directly to Ethereum node (#21)
f2eecb1 
* Allow passing arguments directly to Ethereum node

- Fixes #19

* Problem: Error when --nodeArguments are missing

Make sure to pass no arguments when nodeArguments value is falsy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow passing arguments directly to Ethereum node TimDaub/ethnode
1 participant
@TimDaub