-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all and parser errors handler #92
Conversation
after playing around with it, I think the parser error stuff is fine (although I haven't tried to recreate all different error conditions). the fix all part is somehow misbehaving for me. it doesn't show up in the quickfix popup unless I do '<right click> -> Source Action... '. when I put since we'll have to release 2.28.0 soon, I would suggest splitting your PR in two. one for parser errors and one for "fix all". so we can include parser error handling in 2.28.0 and can deal with fix all later. |
Are you sure |
I'm not sure if it should pop up, I'm just wondering why it doesn't, since it gets added regardless of number of fixes.
I assume that applies to most if not all parser errors, so a fix all is a bit misleading for them, until we have more things that get fixed in the future. I'm not sure what issues we can include in these fix all / auto-fixes, since they would have to be ones that don't require user input.
I didn't resave very fast, however somehow the last parser error remains after saving sometimes, so the third save would still see that parser error and add a second
I'm unsure on that, maybe someone using an alternative editor can chime in. |
88fd7d2
to
1ac2131
Compare
Can be tested with
settings.json
:Fixes missing semicolons, commas, overrides and changes
final var
tofinal
for now.Depends on vshaxe/vshaxe#576
I think we need to name all code actions like this: https://dartcode.org/docs/refactorings-and-code-fixes/
And then add enum for
fixAll
command in settings to make customizable list of autofixes (instead of currentquickfix.auto
kind)?Also i need some explanation what two first early returns in
ParserErrorActions
are doing, this is copypasted from other file.