Skip to content

Conversation

eitanbehar
Copy link
Contributor

No description provided.

@vsoch
Copy link
Owner

vsoch commented Mar 11, 2021

This is great! A few tweaks before we merge:

Alignment

The alignment of the icons for the parent docsy are in a row:

image

but the PR here has them stacked - could we have them in a row as well?

image

Changelog and Version

We should have an entry in the changelog to describe the versions, and also update the VERSION file in the repository root to 0.0.21.

@eitanbehar
Copy link
Contributor Author

Thanks for the prompt feedback. I would love to fix the commit.
Where can I see the code for the row-aligned icons (just to be sure we are on the same baseline).
footer.html on the parent repo only has a link to Twitter in the left margin, and the link to Github is aligned to the right.
image

@vsoch
Copy link
Owner

vsoch commented Mar 11, 2021

Right here -> https://www.docsy.dev/docs/

That's correct - the GitHub icon should be on the right, but then other icons added on the left should be in a line.

@eitanbehar
Copy link
Contributor Author

Thanks. Fixed, PR updated. I think it would be a good idea to squash the commits for a cleaner history.

@vsoch vsoch merged commit 7e7b335 into vsoch:master Mar 11, 2021
@vsoch
Copy link
Owner

vsoch commented Mar 11, 2021

Looks perfect! Thank you!

@eitanbehar
Copy link
Contributor Author

Thanks to you for this nice and helpful project :)

eitanbehar added a commit to eitanbehar/docsy-jekyll-contrib that referenced this pull request Mar 11, 2021
add support in footer to linkedin url (vsoch#41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants