Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[distrubution-spec] Add custom transport adapter to client #10

Closed
vsoch opened this issue Oct 15, 2020 · 2 comments
Closed

[distrubution-spec] Add custom transport adapter to client #10

vsoch opened this issue Oct 15, 2020 · 2 comments

Comments

@vsoch
Copy link
Owner

vsoch commented Oct 15, 2020

I want to check on what are the reasons/ advantages to creating a custom transport adapter, as is done here. The python requests library allows for definition of a similar thing: https://requests.readthedocs.io/en/master/user/advanced/#transport-adapters. @jdolitsky sorry for the multiple pokes today! If you have a few minutes in the next week or so to give a quick answer, it will definitely be helpful! For the meantime I'm going to skip creating the custom adapter.

@jdolitsky
Copy link
Contributor

@vsoch it is probably not needed. In looking in the differences, I'm seeing DisableCompression: true,, which I think turns off the header Accept-Encoding: gzip that the Go http lib adds automatically. We were trying to control all headers sent for conformance reasons, but its probably unnecessary/overkill.

@vsoch
Copy link
Owner Author

vsoch commented Oct 19, 2020

Closing because not needed!

@vsoch vsoch closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants