generated from vtex-sites/base.store
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add MSW addon config #143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-32237a0--gatsby.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 32237a0
|
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
ArthurTriis1
force-pushed
the
Add-Storybook-MSW-addon
branch
from
July 11, 2022 15:46
d24f8e6
to
b255600
Compare
lucasfp13
approved these changes
Jul 11, 2022
victorhmp
approved these changes
Jul 11, 2022
eduardoformiga
pushed a commit
that referenced
this pull request
Jul 11, 2022
* Feat: Adds tokens to `ImageGallery` (#143) * Removes unused icons file * Removes unnecessary data-attr * Adds default stories mdx * Renames data-store-image to data-fs-image * Moves image styles to layout.scss * Adjusts tokens for image-gallery * Renames `data-thumbnail-button` to `data-fs-image-gallery-selector-thumbnail` * Adds `data-fs-image-gallery-selector-control-button` data-attr` * Adds image-gallery-selector-elements tokens * Adds tokens data-fs-image-gallery-selector-thumbnail data-attr * Adds tokens documentation * Removes unused args paramenter * Convert px to rem * Updates title * Adds `-mobile` * Updates description * Updates changelog * Updates tokens variables with global tokens * Renames thumbnail selected border color token * Adding Variants section * Reorders Variants section place * Updates Changelog * Removes Image styles import from `Layout` * Fixes `OutOfStock` bug Co-authored-by: Fanny Chien <fannychienn@gmail.com>
ArthurTriis1
force-pushed
the
Add-Storybook-MSW-addon
branch
from
July 11, 2022 20:37
d5a383a
to
f506a3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arthur Andrade arthurfelandrade@gmail.com
What's the purpose of this pull request?
This PR adds the Mock Service Worker Addon in storybook, and configures the API mock for TopSearch component.
How to test it?
The result can be seen in TopSearch storybook preview
References
Mock Service Worker Addon
Checklist
You may erase this after checking them all ;)
Changelog
CHANGELOG.md
at the beginning of its due section. The latest version should comes first.CHANGELOG.md
. E.g., New items in thepull_request_template.md
(#4)PR Description
Breaking change
,Enhancement
,Bug
orChore
.ComponentName
component.useWindowDimensions
hook.Documentation