Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add MSW addon config #143

Merged
merged 3 commits into from
Jul 11, 2022
Merged

feat: Add MSW addon config #143

merged 3 commits into from
Jul 11, 2022

Conversation

ArthurTriis1
Copy link
Contributor

@ArthurTriis1 ArthurTriis1 commented Jul 11, 2022

Signed-off-by: Arthur Andrade arthurfelandrade@gmail.com

What's the purpose of this pull request?

This PR adds the Mock Service Worker Addon in storybook, and configures the API mock for TopSearch component.

How to test it?

The result can be seen in TopSearch storybook preview

Screen Shot 2022-07-07 at 13 36 02

References

Mock Service Worker Addon

Checklist

You may erase this after checking them all ;)

Changelog

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
  • Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.
  • For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

@vercel
Copy link

vercel bot commented Jul 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gatsby-store-storybook ✅ Ready (Inspect) Visit Preview Jul 11, 2022 at 8:40PM (UTC)

@vtex-sites
Copy link

vtex-sites bot commented Jul 11, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-32237a0--gatsby.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit 32237a0

@vtex-sites
Copy link

vtex-sites bot commented Jul 11, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit 32237a0

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
eduardoformiga pushed a commit that referenced this pull request Jul 11, 2022
* Feat: Adds tokens to `ImageGallery` (#143)

* Removes unused icons file

* Removes unnecessary data-attr

* Adds default stories mdx

* Renames data-store-image to data-fs-image

* Moves image styles to layout.scss

* Adjusts tokens for image-gallery

* Renames `data-thumbnail-button` to `data-fs-image-gallery-selector-thumbnail`

* Adds `data-fs-image-gallery-selector-control-button` data-attr`

* Adds image-gallery-selector-elements tokens

* Adds tokens data-fs-image-gallery-selector-thumbnail data-attr

* Adds tokens documentation

* Removes unused args paramenter

* Convert px to rem

* Updates title

* Adds `-mobile`

* Updates description

* Updates changelog

* Updates tokens variables with global tokens

* Renames thumbnail selected border color token

* Adding Variants section

* Reorders Variants section place

* Updates Changelog

* Removes Image styles import from `Layout`

* Fixes `OutOfStock` bug

Co-authored-by: Fanny Chien <fannychienn@gmail.com>
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
@ArthurTriis1 ArthurTriis1 merged commit 32237a0 into main Jul 11, 2022
@ArthurTriis1 ArthurTriis1 deleted the Add-Storybook-MSW-addon branch July 11, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants