Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adds tokens to SlideOver #145

Merged
merged 59 commits into from
Jul 11, 2022
Merged

Conversation

eduardoformiga
Copy link
Member

@eduardoformiga eduardoformiga commented Jun 23, 2022

What's the purpose of this pull request?

This PR applies the new Theming structure to SlideOver: new scoped tokens linked to global ones.

It also Adds CSS Modules to the CartSidebar, with themification tokens and Stories.

How does it work?

This PR uses local variables to parameterize the SlideOver, and CartSidebar properties, then connect these scoped tokens to the global ones.

Tokens can be visualized in the storybook.

How to test it?

  • The SlideOver component and its related components should look just as it was before these changes.
  • The CartSidebar component and its related components should look just as it was before these changes.
  • You can check the story on Storybook.

Checklist

Changelog

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
  • Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.
  • For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

@vercel vercel bot temporarily deployed to Preview July 7, 2022 15:39 Inactive
Co-authored-by: Renata Motta <renata.motta@vtex.com.br>
@vercel vercel bot temporarily deployed to Preview July 7, 2022 15:44 Inactive
@vercel vercel bot temporarily deployed to Preview July 7, 2022 15:46 Inactive
@vercel vercel bot temporarily deployed to Preview July 7, 2022 15:51 Inactive
@vercel vercel bot temporarily deployed to Preview July 7, 2022 18:10 Inactive
@vercel vercel bot temporarily deployed to Preview July 7, 2022 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview July 7, 2022 19:33 Inactive
Copy link
Collaborator

@renatamottam renatamottam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/components/cart/CartSidebar/CartSidebar.tsx Outdated Show resolved Hide resolved
src/components/ui/SlideOver/SlideOver.tsx Outdated Show resolved Hide resolved
eduardoformiga and others added 3 commits July 8, 2022 15:31
Co-authored-by: Victor Hugo Miranda Pinto <victor2142@gmail.com>
Co-authored-by: Victor Hugo Miranda Pinto <victor2142@gmail.com>
@vercel vercel bot temporarily deployed to Preview July 8, 2022 18:34 Inactive
@eduardoformiga eduardoformiga merged commit a621b81 into main Jul 11, 2022
@eduardoformiga eduardoformiga deleted the feat/theming-slide-over-fsss-385 branch July 11, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Features New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants