Add rule no-static-element-interactions
#680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhoyer
requested changes
Jan 12, 2023
|
Thanks @vhoyer – the PR has been updated following your review. |
vhoyer
approved these changes
Jan 13, 2023
|
the CI has failed, can you fix it? |
EDIT: I needed to update from upstream, it's all good now. |
|
Looks good, thanks for the contribution! |
|
Hey! thanks for the merge :D |
|
@ror-y thanks for the PR :D |
My pleasure 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add an adaptation of the
no-static-element-interactionsfound in https://github.com/jsx-eslint/eslint-plugin-jsx-a11y.Demo
Tests
Disclaimer
This is my first contribution so feel free to scrutinise.