Skip to content

feat: Added custom transition object support #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 21, 2021
Merged

feat: Added custom transition object support #62

merged 6 commits into from
Mar 21, 2021

Conversation

fatihsolhan
Copy link
Contributor

This feature will allow us to define custom transition object.

Tailwind example:

<template>
  <vue-final-modal
    :transition="{
      'enter-active-class': 'transition duration-200 ease-in-out transform',
      'enter-class': 'translate-y-full',
      'enter-to-class': 'translate-y-0',
      'leave-active-class': 'transition duration-200 ease-in-out transform',
      'leave-to-class': 'translate-y-full',
      'leave-class': 'translate-y-0'
    }"
  >
    ...modal content
  </vue-final-modal>
</template>

transition-gif

@hunterliu1003
Copy link
Member

Hi @fatihsolhan

Thanks for your work that make vue-final-modal much better.

I’m so busy this week, I will merge the PR on the weekend and will release a new version next week.

It will be perfect if you can send another PR to branch v3 which supports for Vue 3.

🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉

@Mini-ghost,
Please help me to confirm if there is nothing missing here.

@hunterliu1003 hunterliu1003 merged commit 541d57c into vue-final:master Mar 21, 2021
@hunterliu1003
Copy link
Member

Hi @fatihsolhan,

The PR has released in v2.1.0

@hunterliu1003
Copy link
Member

Hi @fatihsolhan,

I just start merge the PR into branch v3 for Vue 3.
Hope you haven't started it.

@fatihsolhan
Copy link
Contributor Author

Hi @fatihsolhan,

I just start merge the PR into branch v3 for Vue 3.

Hope you haven't started it.

Hi @hunterliu1003
I started yesterday but there was an issue which transition wasn't working correctly. But I was a bit busy and couldn't continue to working on it. Please let me know if you see same issue

@hunterliu1003
Copy link
Member

@fatihsolhan,

Thank you very much for your help again.
I will do the rest part.

@Roxas92
Copy link
Contributor

Roxas92 commented Mar 24, 2021

Hi @fatihsolhan,
I just start merge the PR into branch v3 for Vue 3.
Hope you haven't started it.

Hi @hunterliu1003
I started yesterday but there was an issue which transition wasn't working correctly. But I was a bit busy and couldn't continue to working on it. Please let me know if you see same issue

@fatihsolhan Is the issue you are talking about related to the entry transition? Haven't seen your PR and tried to get an object configuration working as well but I became desperate because the entry transition isn't working :D So I was wondering if you face the same issue.

@fatihsolhan
Copy link
Contributor Author

fatihsolhan commented Mar 24, 2021

Hi @fatihsolhan,

I just start merge the PR into branch v3 for Vue 3.

Hope you haven't started it.

Hi @hunterliu1003

I started yesterday but there was an issue which transition wasn't working correctly. But I was a bit busy and couldn't continue to working on it. Please let me know if you see same issue

@fatihsolhan Is the issue you are talking about related to the entry transition? Haven't seen your PR and tried to get an object configuration working as well but I became desperate because the entry transition isn't working :D So I was wondering if you face the same issue.

Hi @Roxas92
No, my issue was not related to entry transition.
If you are using Vue3, please be sure you are using enter-from-class instead of enter-class
It changed with Vue3

Vue3 docs for vue-final-modal with custom transition https://v3.vue-final-modal.org/examples/tailwind#custom-transition-example

@hunterliu1003
Copy link
Member

Hi @Roxas92,

Sorry for published the Vue 3 version of the issue for transition object late.

Now you can upgrade vue-final-modal to v3.1.0 for transition object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants