fixes #341 - introduced debounce functionality into formatValueToModel
#360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmatValueToModel` * Updated to fecha 2.3.2 * Moved the majority of logic from computed.value.set() to new `updateModelValue(newValue, oldValue)` method to allow other components to use similar techniques. If `formatValueToModel` returns a function, then the function is called without setting the model value. It is the functions responsibility to call `this.updateModelValue(newValue, oldValue)`. Otherwise, calls `this.updateModelValue(newValue, oldValue)` to execute the original logic. * If the input type is date, datetime, or datetime-local then it creates a debounced function for setting the value in fieldInput's mounted hook and then returns a function that calls this debounced function from `formatValueToModel` * Reduced the repeated code for date formatting by adding a DATETIME_FORMATS constant, and using that to get the "format" for fecha.parse()
|
Hmm, Travis is not working after organization. I'm fixing. |
|
Could you modify a file (some space or enter) that the travis will be triggered? |
|
Well that's interesting, |
|
Travis was linked to the old "icebob/vue-form-generator" repo :) |
|
I was referring to the failure - Travis said I missed a comma and failed the validation, but on my end everything passed without error/warnings. |
|
Hmm, interesting. |
|
Thanks, great PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to fecha 2.3.2
Moved the majority of logic from computed.value.set() to new
updateModelValue(newValue, oldValue)method to allow other components to use similar techniques.If
formatValueToModelreturns a function, then the function is called without setting the model value. It is the functions responsibility to callthis.updateModelValue(newValue, oldValue).Otherwise, calls
this.updateModelValue(newValue, oldValue)to execute the original logic.If the input type is date, datetime, or datetime-local then it creates a debounced function for setting the value in fieldInput's mounted hook and then returns a function that calls this debounced function from
formatValueToModelReduced the repeated code for date formatting by adding a DATETIME_FORMATS constant, and using that to
get the "format" for fecha.parse()